refactor(AutoFill): prevent jitter when mouse scrolling too fast #5670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request refactors the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The change from
<ul>to<div>for dropdown menus might affect existing CSS styles; ensure compatibility. - Removing
AddClassFromAttributesmight break some existing styling; consider if there's a better way to handle this.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5670 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 654 654
Lines 29683 29690 +7
Branches 4216 4216
===========================================
+ Hits 29683 29687 +4
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5669
Summary By Copilot
This pull request includes several changes to the
BootstrapBlazorproject, focusing on theAutoFillandAutoCompletecomponents. The changes aim to improve the layout, functionality, and performance of these components.Changes to
AutoFillComponent:classattributes fromAutoFillelements to simplify the markup. [1] [2] [3] [4] [5] [6]Model5andItems5and updated the logic to use these properties. [1] [2] [3] [4]<ul>to<div>for better styling and flexibility. [1] [2] [3]RowHeightandOverscanCountto improve virtual scrolling performance.PlaceHolderStyleStringto handle custom row height styles.OnClearValueandLoadItemsmethods to reset state and optimize rendering. [1] [2]Changes to
AutoCompleteComponent:<ul>to<div>for consistency and better styling. [1] [2]PopoverCompleteBase.cs.General Updates:
9.5.0-beta09.These changes collectively enhance the usability and performance of the
AutoFillandAutoCompletecomponents in theBootstrapBlazorproject.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refactors the AutoFill and AutoComplete components to improve layout, functionality, and performance. Addresses jittering issues during fast mouse scrolling by adjusting virtual scrolling parameters and optimizing rendering logic.
Enhancements:
to for better styling and flexibility.
- Optimizes the OnClearValue and LoadItems methods in the AutoFill component to reset state and improve rendering.
- Adds logic to apply custom classes and offsets to the AutoComplete dropdown menu based on attributes.
- Removes unnecessary class attributes from AutoFill elements to simplify the markup.
- Adds a new property PlaceHolderStyleString to handle custom row height styles in the AutoFill component.
- Adjusts the default offset for the dropdown menu in PopoverCompleteBase.cs.
- Introduces Model5 and Items5 properties to the AutoFill component and updates the logic to use these properties.